PACT-709: First implementation of stub #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwalpole
force-pushed
the
PACT-709
branch
2 times, most recently
from
bf995c4 to
92743cf
Compare
|
I'm having a bit of trouble getting this to run, following the README. Bringing up the containers is fine: However: Am I missing a step? |
|
@tna-erasmos until such a time as these two PRs fp-in-bo/jms4s#363 & fp-in-bo/jms4s#359 have been merged we will have to maintain a hybrid version which has both which I have created here . You will need to check out this |
|
@rwalpole, how about we put those instructions in the README, temporarily? |
|
@tna-erasmos, sure, updated README. |
|
Some progress. I built this branch of However, It was due to I changed this to: And it worked. And from the Elastic MQ console at http://localhost:9325/, I can see that there are two queues:
I'm guessing that the other queue is for responses. Now I just need to figure out how to take it for a spin. |
|
I sorted it; see my QA here. I'll start to review the code, itself. |
ghost
approved these changes
Feb 1, 2023
| # JMS4s Request-Reply Stub |
There was a problem hiding this comment.
Could we add some instructions for demonstrating this, using the restful API?
See this comment.
| private implicit val logger: SelfAwareStructuredLogger[IO] = logging.getLogger | ||
| private val clientId = "echo_server_1" | ||
| private val requestQueue = QueueName("request-general") | ||
| private val replyQueue = QueueName("omega-editorial-web-application-instance-1") //TODO(AR) note this is for the editorial web application |
There was a problem hiding this comment.
Perhaps it's clear enough without the comment?
| private val jmsClient: Resource[IO, JmsClient[IO]] = simpleQueueService.makeJmsClient[IO]( | ||
| Config( | ||
| endpoint = Endpoint(Some(DirectAddress(HTTP, "localhost", Some(9324))),"elasticmq"), | ||
| credentials = Some(Credentials("x","x")), |
| consumer <- client.createAcknowledgerConsumer(requestQueue, concurrencyLevel = consumerConcurrencyLevel, pollingInterval = 50.millis) | ||
| } yield consumer | ||
|
|
||
| consumerRes.use(_.handle { (jmsMessage, mf) => |
| _ <- IO.println(s"Echo Server received message: $requestText") | ||
| responseText <- IO.pure(s"Echo Server: $requestText") | ||
| responseMessage <- mf.makeTextMessage(responseText) | ||
| // PERFORM THE ACTUAL SERVICE HERE |
There was a problem hiding this comment.
Is this note still needed (ACTUAL SERVICE)?
| responseText <- IO.pure(s"Echo Server: $requestText") | ||
| responseMessage <- mf.makeTextMessage(responseText) | ||
| // PERFORM THE ACTUAL SERVICE HERE | ||
| // NOTE(AR) set correlationId on response message to the request message id |
There was a problem hiding this comment.
Perhaps it's clear enough without the comment?
|
|
||
| queues { | ||
| request-general { } | ||
| omega-editorial-web-application-instance-1 { } |
ghost
suggested changes
Feb 1, 2023
felixgb
reviewed
Feb 2, 2023
| override def run(args: List[String]): IO[ExitCode] = { | ||
|
|
||
| val consumerRes = for { | ||
| _ <- Resource.liftK(IO.println("Starting EchoServer...")) |
There was a problem hiding this comment.
Not 100% sure how cats effects IO class works, but do we want to use the logger here instead of println?
felixgb
reviewed
Feb 2, 2023
| import sbt._ | ||
|
|
||
| object Dependencies { | ||
| lazy val scalaTest = "org.scalatest" %% "scalatest" % "3.2.11" |
There was a problem hiding this comment.
Is file used at all?
Also, are we going to be using scalatest or Munit?
|
Now I'm wondering if we need this stub service at all. I had expected that this would have been integrated into I'll bring it up at standup. |
|
@rwalpole has explained that two attempts were already made to integrate the stub inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.