Updated version to v3.11-beta #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
==========================================
+ Coverage 68.71% 70.40% +1.69%
==========================================
Files 39 47 +8
Lines 15207 15410 +203
Branches 3143 3161 +18
==========================================
+ Hits 10449 10849 +400
+ Misses 1700 1519 -181
+ Partials 3058 3042 -16 ☔ View full report in Codecov by Sentry. |
kozlovic
approved these changes
Feb 28, 2025
CMakeLists.txt
Outdated
| set(NATS_VERSION_PATCH 0) | ||
| set(NATS_VERSION_SUFFIX "-beta") | ||
|
|
||
| set(NATS_VERSION_REQUIRED_NUMBER 0x030900) | ||
| set(NATS_VERSION_REQUIRED_NUMBER 0x030B00) |
There was a problem hiding this comment.
Just FYI, this number really needs to change only when there would be an "incompatibility" between versions. So until we modify/change some of the structure/functions in nats.h, there is technically no need to bump the version required number.
There was a problem hiding this comment.
Right, sorry my mistake. I changed it back to 0A, and will update the release doc to explicitly say that it should change in the PRs that modify the API structs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.