Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update neurons #138

Merged
merged 7 commits into from
Aug 14, 2022
Merged

Feature/update neurons #138

merged 7 commits into from
Aug 14, 2022

Conversation

jefferis
Copy link
Collaborator

Still thinking about these additions from @alexanderbates

@jefferis
Copy link
Collaborator Author

Split away from #130

@jefferis
Copy link
Collaborator Author

@alexanderbates I would suggest combining these into a single function e.g. update_neuronlist. In general if a function does something closely related and returns the same kind of object then I would consider combining. In this case you have an argument to control which kind of update is required (with a default to update everything). Note also that read.neurons.catmaid actually fetches neuron names.

1 similar comment
@jefferis
Copy link
Collaborator Author

@alexanderbates I would suggest combining these into a single function e.g. update_neuronlist. In general if a function does something closely related and returns the same kind of object then I would consider combining. In this case you have an argument to control which kind of update is required (with a default to update everything). Note also that read.neurons.catmaid actually fetches neuron names.

@alexanderbates
Copy link
Collaborator

Okay, done!

@jefferis jefferis merged commit a679c62 into master Aug 14, 2022
@jefferis jefferis deleted the feature/update-neurons branch August 14, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants