Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generate_app_test_data management command. #809

Merged
merged 8 commits into from
Feb 10, 2025

Conversation

gsnider2195
Copy link
Contributor

@gsnider2195 gsnider2195 commented Sep 11, 2024

This is a basic management command that generates some models so that basic development can be done on this app without using a database backup or real device access. This should be run directly after nautobot core's generate_test_data management command.

Screenshots

{CDD4E24A-84F2-408A-A818-D8AA34B412C4}

image

TODO

  • Documentation
  • Change fragment

@gsnider2195 gsnider2195 marked this pull request as ready for review September 11, 2024 22:43
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to call out that this name should be more specific to the particular app. If another app were to implement the same command for their own testing, they would conflict with each other. While Django handles this, this could cause a different generate_app_test_data run than what we may want.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like for this to be called by core's generate_test_data so hopefully this would move into a separate module and be referenced by NautobotAppConfig. I don't plan on rolling out this management command to every app.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to nautobot-server generate_gc_test_data

@gsnider2195 gsnider2195 added the emergent Unplanned work that is brought into a sprint after it's started. label Sep 19, 2024
@jeffkala
Copy link
Contributor

jeffkala commented Feb 6, 2025

@gsnider2195 what is this waiting on? Anything?

@gsnider2195
Copy link
Contributor Author

@gsnider2195 what is this waiting on? Anything?

Maintainer approval

Copy link
Contributor

@jeffkala jeffkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests aren't passing, besides that I'm good.

@gsnider2195
Copy link
Contributor Author

Test failures are coming from the source branch

@gsnider2195 gsnider2195 merged commit 908efc5 into develop Feb 10, 2025
10 of 12 checks passed
@gsnider2195 gsnider2195 deleted the u/gas-generate-test-data branch February 10, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emergent Unplanned work that is brought into a sprint after it's started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants