Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvp config plan post processing #874

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Conversation

jeffkala
Copy link
Contributor

@jeffkala jeffkala commented Jan 31, 2025

Closes: #875

What's Changed

MVP to support post-processing view in config-plans as well as a post-processing step before deploying config plans. The idea is to make this more of an agile approach to this feature. this solve the problem, but should be exanded upon in the future to harden as needed.

To Do

  • Explanation of Change(s)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@jeffkala
Copy link
Contributor Author

One consideration to keep in mind is that on the deployment itself, the current functionality prints a napalm configure diff representation. This diff goes through the standard SANTIZER_PATTERN but that pattern doesn't naturally intend to catch "configuration syntax's". At this time it is catching most of the username: password: style syntaxes, but probably need to remove the diff from the job log entry completely to be safe.

@jeffkala
Copy link
Contributor Author

jeffkala commented Feb 4, 2025

One consideration to keep in mind is that on the deployment itself, the current functionality prints a napalm configure diff representation. This diff goes through the standard SANTIZER_PATTERN but that pattern doesn't naturally intend to catch "configuration syntax's". At this time it is catching most of the username: password: style syntaxes, but probably need to remove the diff from the job log entry completely to be safe.

nautobot/nornir-nautobot#174 to attempt to add an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the MVP for Config Plan Post Processing
1 participant