Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Flask custom CLI commands for custom scripts #138

Merged
merged 52 commits into from
Feb 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
c422aa6
Rename route package to api
lorenyu Feb 9, 2023
45b108a
Make REST resource name plural
lorenyu Feb 9, 2023
54d0b33
Remove unused route_utils module
lorenyu Feb 9, 2023
f2b7cd5
Use consistent import styles
lorenyu Feb 9, 2023
56d2afc
Remove extraneous print statement
lorenyu Feb 9, 2023
6fefac1
Remove extra whitespace
lorenyu Feb 9, 2023
c9630b6
Reorganize user blueprint
lorenyu Feb 9, 2023
6d1d7df
Update apiflask
lorenyu Feb 9, 2023
bb64fa3
Add create-csv command
lorenyu Feb 9, 2023
a373ccb
Update openapi.yml
lorenyu Feb 9, 2023
941cb06
Move local.env to .env.template
lorenyu Feb 9, 2023
42b5d49
Remove unused poetry command
lorenyu Feb 9, 2023
cc9654b
Add Makefile command for Flask CLI
lorenyu Feb 9, 2023
1e365e1
Add help messages
lorenyu Feb 9, 2023
95be2d7
Add make setup-local
lorenyu Feb 9, 2023
6d65a04
Revert "Move local.env to .env.template"
lorenyu Feb 9, 2023
75ca748
Reorganize Makefile commands
lorenyu Feb 9, 2023
716128f
Add comment
lorenyu Feb 9, 2023
78da5d2
Whitespace
lorenyu Feb 9, 2023
dfe2dd3
Add cli_runner fixture
lorenyu Feb 9, 2023
11096e8
Move isolated db stuff to create user csv
lorenyu Feb 11, 2023
6e177cd
Install pytest lazy fixture
lorenyu Feb 11, 2023
6aecce5
Simplify assertion
lorenyu Feb 11, 2023
7053d91
Remove unused utils
lorenyu Feb 11, 2023
662ac67
Lint
lorenyu Feb 11, 2023
6daef3e
Add test for default filename
lorenyu Feb 11, 2023
020c4cf
Remove unused main function
lorenyu Feb 11, 2023
f1a29eb
Remove script_util
lorenyu Feb 11, 2023
1459046
Add comment to cli command
lorenyu Feb 13, 2023
badb082
Rename cli to cmd
lorenyu Feb 13, 2023
4cc0af4
Add help messages to cmd params
lorenyu Feb 13, 2023
69f3848
Remove unused env var
lorenyu Feb 15, 2023
0dc857f
Rename source directory from api to src
lorenyu Feb 16, 2023
45b9e3f
Remove rollback logic from test
lorenyu Feb 16, 2023
e55bd99
Revert "Remove rollback logic from test"
lorenyu Feb 21, 2023
5622433
Revert "Rename source directory from api to src"
lorenyu Feb 21, 2023
aeff01a
Remove rollback logic from test
lorenyu Feb 21, 2023
55c2339
Add migration to cascade on delete
lorenyu Feb 21, 2023
23a1a75
Truncate user table in create csv test
lorenyu Feb 21, 2023
ddc6313
Move empty_schema fixture to test_migrations
lorenyu Feb 21, 2023
b83213b
Rename factories_db_session fixture
lorenyu Feb 21, 2023
6fc18d1
Lint
lorenyu Feb 21, 2023
7e3cfc8
Rename preopopulate fixture
lorenyu Feb 21, 2023
1a115af
Move empty_schema fixture to correct file
lorenyu Feb 21, 2023
00be3be
Combine truncate and prepopulate fixture
lorenyu Feb 21, 2023
2c01c76
Add comments
lorenyu Feb 21, 2023
83ccce0
Rename db var to avoid name conflict
lorenyu Feb 21, 2023
cd39d03
Merge remote-tracking branch 'origin/main' into lorenyu/scripts
lorenyu Feb 21, 2023
81868e9
isort
lorenyu Feb 21, 2023
873939c
Add known first party
lorenyu Feb 21, 2023
1e2788b
Revert "Add known first party"
lorenyu Feb 21, 2023
0a837a8
Add comment
lorenyu Feb 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename preopopulate fixture
lorenyu committed Feb 21, 2023
commit 7e3cfc8c5046207bc8be9b31508a9efd42b8dcec
8 changes: 4 additions & 4 deletions app/tests/api/scripts/test_create_user_csv.py
Original file line number Diff line number Diff line change
@@ -13,12 +13,12 @@


@pytest.fixture
def truncate_user(db_session: db.Session):
def truncate_user_table(db_session: db.Session):
db_session.query(User).delete()


@pytest.fixture
def prepopulated_users(enable_factory_create) -> list[User]:
def prepopulate_user_table(enable_factory_create) -> list[User]:
return [
UserFactory.create(first_name="Jon", last_name="Doe", is_active=True),
UserFactory.create(first_name="Jane", last_name="Doe", is_active=False),
@@ -43,9 +43,9 @@ def tmp_s3_folder(mock_s3_bucket):
],
)
def test_create_user_csv(
truncate_user,
truncate_user_table,
prepopulate_user_table: list[User],
cli_runner: flask.testing.FlaskCliRunner,
prepopulated_users: list[User],
dir: str,
):
cli_runner.invoke(args=["user", "create-csv", "--dir", dir, "--filename", "test.csv"])