Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode API Debugger #222

Merged
merged 13 commits into from
Apr 15, 2024
Merged

VSCode API Debugger #222

merged 13 commits into from
Apr 15, 2024

Conversation

rylew1
Copy link
Contributor

@rylew1 rylew1 commented Apr 4, 2024

Ticket

Resolves #TODO

Changes

  • Add API debugging ability from VSCode

Do we want to commit IDE specific files (.vscode/launch.json) ?

  • I don't see it in the frontend template project

Context for reviewers

  • It seems you can't run run-logs alongside start-debug for some reason - the 5678 port won't be exposed

  • Demo running make start-debug, then connect with the VSCode launcher:

Screen.Recording.2024-04-05.at.12.55.13.PM.mov

@rylew1 rylew1 requested a review from chouinar April 4, 2024 21:34
app/src/app.py Outdated Show resolved Hide resolved
docker-compose.debug.yml Outdated Show resolved Hide resolved
app/src/app.py Outdated Show resolved Hide resolved
@rylew1 rylew1 marked this pull request as ready for review April 5, 2024 19:39
@@ -92,6 +92,9 @@ build:
start:
docker compose up --detach

start-debug:
docker compose -f ../docker-compose.yml -f ../docker-compose.debug.yml up --detach

Copy link
Contributor Author

@rylew1 rylew1 Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug file gets launched second to be more clear that it overrides value in the normal docker compose

@rylew1 rylew1 self-assigned this Apr 5, 2024
@rylew1 rylew1 added the enhancement New feature or request label Apr 5, 2024
@rylew1 rylew1 added this to the Framework milestone Apr 5, 2024
@rylew1 rylew1 requested a review from chouinar April 5, 2024 23:23
@rylew1 rylew1 merged commit 5730b46 into main Apr 15, 2024
4 checks passed
@rylew1 rylew1 deleted the rylew/vscode-debugger branch April 15, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants