Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Set consistent timezone for tests (#209)" #210

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Revert "Set consistent timezone for tests (#209)" #210

merged 1 commit into from
Sep 18, 2023

Conversation

sawyerh
Copy link
Contributor

@sawyerh sawyerh commented Sep 18, 2023

This reverts commit 5db0cea.

Context for reviewers

Projects can mock timezone within the relevant tests. Mocking globally could hide bugs. See convo on #209.

lorenyu
lorenyu approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@lorenyu lorenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If testing timezone related features ends up being a common need, we could potentially include some guidance in some sort of testing.md doc that could have a section explaining what to do if you are testing something that relies on timezones.

@sawyerh sawyerh merged commit d64c608 into main Sep 18, 2023
6 checks passed
@sawyerh sawyerh deleted the revert-209-sawyerh/set-jest-timezone branch September 18, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenyu lorenyu lorenyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sawyerh @lorenyu