Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor e2e/lib/EmailService #898

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Refactor e2e/lib/EmailService #898

merged 1 commit into from
Mar 10, 2025

Conversation

lorenyu
Copy link
Contributor

@lorenyu lorenyu commented Mar 10, 2025

Ticket

n/a

Changes

  • Refactor EmailService#generateEmailAddress to accept a username
  • Add EmailService#generateUsername

Context for reviewers

Wanted to be able to control the username in tests to generate admin usernames

Testing

see https://github.com/navapbc/pfml-starter-kit-app/pull/275

@lorenyu lorenyu merged commit 033f6a6 into main Mar 10, 2025
2 checks passed
@lorenyu lorenyu deleted the lorenyu/e2eadmin branch March 10, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant