Consolidate ability to run e2e tests on demand into e2e-tests.yml #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #{TICKET NUMBER OR URL}
Changes
Context for reviewers
This change simplifies the workflows. The extra workflow introduced in #892 isn't necessary to be able to run e2e tests on demand and I realized that we eventually don't want to run e2e tests on merge to main, but rather we want to run e2e tests as part of a deploy, so even then we don't need an extra workflow.
Testing
see https://github.com/navapbc/pfml-starter-kit-app/pull/277