Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 1.13.5 #729

Merged
merged 1 commit into from
Jan 17, 2024
Merged

version 1.13.5 #729

merged 1 commit into from
Jan 17, 2024

Conversation

namsic
Copy link
Collaborator

@namsic namsic commented Jan 15, 2024

1.13.5 버전 릴리즈를 위한 변경을 적용합니다.

  • ChangeLog 변경
    • 형식 변경
    • whitespace 제거
    • 1.13.5 변경 내용 추가
  • version.pl 변경

Preview

릴리즈 노트에서 마크다운 문법이 적용되면 아래와 같이 보여지게 됩니다.
image

@namsic namsic requested review from jhpark816 and oliviarla January 15, 2024 10:56
@namsic namsic force-pushed the release branch 2 times, most recently from b1506e2 to 3b7da85 Compare January 16, 2024 03:02
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

ChangeLog Outdated
* Changed the MAX_ZK_TO value from 300 to 2000 secs.
* Use `<latest-release>-unknown` version when git describe fails.
* Add zk_version to `stats zookeeper` response.
* summarize rejected connection log message occured frequently.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대문자로 시작

ChangeLog Outdated
- ZooKeeper clustering is enabled and cache_list znode is created
- ZooKeeper clustering is disabled
- `NOT_READY`
- ZooKeeper clustering is enabled but znode is not created
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아래 정도로 표현하면 어떤가요?

Add ready command to verify that the cache server can receive requests. In Zookeeper clustering, the cache node becomes ready state after creating its cache_list znode. #707

ChangeLog Outdated
* Use `<latest-release>-unknown` version when git describe fails.
* Add zk_version to `stats zookeeper` response.
* summarize rejected connection log message occured frequently.
* Modify mismatched between log level and verbose.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mismatched => mismatches

@jhpark816 jhpark816 merged commit b9bb4b2 into naver:develop Jan 17, 2024
1 check passed
@namsic namsic deleted the release branch January 17, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants