INTERNAL: Prevent overflow when convert string to 32bit int #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpark816
reviewed
Jan 19, 2024
util.c
Outdated
| @@ -74,7 +74,7 @@ bool safe_strtoul(const char *str, uint32_t *out) { | |||
| errno = 0; | |||
|
|
|||
| l = strtoul(str, &endptr, 10); | |||
| if (errno == ERANGE) { | |||
| if (UINT32_MAX < l || errno == ERANGE) { | |||
There was a problem hiding this comment.
error 먼저 검사하고, l 값이 왼쪽에 상수는 오론쪽에 나오게 하시죠.
if (error == ERANGE || l > UINT32_MAX) {
util.c
Outdated
| @@ -100,7 +100,7 @@ bool safe_strtol(const char *str, int32_t *out) { | |||
| *out = 0; | |||
| char *endptr; | |||
| long l = strtol(str, &endptr, 10); | |||
| if (errno == ERANGE) | |||
| if (INT32_MIN > l || INT32_MAX < l || errno == ERANGE) | |||
There was a problem hiding this comment.
if (errno == ERANGE || l < INT32_MIN || l > INT32_MAX)
|
@jhpark816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
문자열을 32bit 정수 자료형 변환 과정이 3단계(
string->long(64bit)->int(32bit))로 이루어짐으로써overflow 발생 시 undefined value로 변환되는 현상을 수정합니다.
해당 현상 발생시 return false를 하도록 수정했습니다.