-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add HashPersist #68
Open
daybrush
wants to merge
9
commits into
naver:master
Choose a base branch
from
daybrush:hash#67
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bb910bf
feat: add HashPersist
daybrush 7146e18
test: fix default tests
daybrush 86a2809
feat: add releaseEvent, replaceHashDepth
daybrush 3b57702
test: test HashPersist
daybrush 538d1cc
docs: fix docs
daybrush 4935598
docs: fix README
daybrush 6676878
skip: apply review
daybrush dd3caf3
feat: add HashPersist types
daybrush b88b08e
fix: fix esm config
daybrush File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
* Copyright (c) 2015 NAVER Corp. | ||
* egjs projects are licensed under the MIT license | ||
*/ | ||
/* eslint-disable class-methods-use-this */ | ||
/* eslint-disable no-use-before-define */ | ||
import {location} from "./browser"; | ||
import {CONST_HASH} from "./consts"; | ||
import Persist from "./Persist"; | ||
|
||
/** | ||
* Get or store the current state of the web page using JSON according to hash. | ||
* @ko 웹 페이지의 현재 상태를 hash에 따라 JSON 형식으로 저장하거나 읽는다. | ||
* @memberof eg.Persist | ||
* @alias eg.Persist.HashPersist | ||
* @extends eg.Persist | ||
* | ||
* @support {"ie": "9+", "ch" : "latest", "ff" : "latest", "sf" : "latest" , "edge" : "latest", "ios" : "7+", "an" : "2.3+ (except 3.x)"} | ||
*/ | ||
class HashPersist extends Persist { | ||
/** | ||
* Read value | ||
* @param {String|Array} [path] - target path | ||
* @return {String|Number|Boolean|Object|Array} | ||
*/ | ||
get(path) { | ||
return this._get(this._getKey(), this._getPath(path)); | ||
} | ||
/** | ||
* Save value | ||
* @param {String|Array} path - target path | ||
* @param {String|Number|Boolean|Object|Array} value - value to save | ||
* @return {Persist} | ||
*/ | ||
set(path, value) { | ||
return this._set(this._getKey(), this._getPath(path), value); | ||
} | ||
/** | ||
* Remove value | ||
* @param {String|Array} [path] - target path | ||
* @return {Persist} | ||
*/ | ||
remove(path) { | ||
return this._remove(this._getKey(), this._getPath(path)); | ||
} | ||
_getKey() { | ||
return `${CONST_HASH}${location.hash}`; | ||
} | ||
_getPath(path) { | ||
let nextPath = path; | ||
|
||
if (Array.isArray(nextPath)) { | ||
nextPath = [this.key, ...nextPath]; | ||
} else { | ||
nextPath = `${this.key}.${nextPath}`; | ||
} | ||
return nextPath; | ||
} | ||
} | ||
|
||
export default HashPersist; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All files are missing the license notification, could you please add it?