-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement class filtering using regular expressions #137
Conversation
Scavenger Test Results163 files 163 suites 1m 33s ⏱️ Results for commit 972d905. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth considering getting the packages
setting as a regular expression.
What do you think of this suggestion?
I agree with your suggestion. |
@sohyun-ku Okay good, that's about the same level of setup as you said. |
That's a good opinion, It's confusing to deal with only one case. |
...r-agent-java/src/main/java/com/navercorp/scavenger/javaagent/collecting/CodeBaseScanner.java
Outdated
Show resolved
Hide resolved
...t-java/src/main/java/com/navercorp/scavenger/javaagent/collecting/ElementMatcherBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
&& (isIncludedByAnnotation(clazz) || isAdditionalPackage(clazz) || isAdditionalByRegex(clazz)) | ||
&& !isExcludedByRegex(clazz); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regular expressions are relatively computationally expensive, so they were placed later in the conditional statements to reduce unnecessary computations.
related to #99
An optional feature is provided to filter classes using regular expressions.
Filtering is based on the result of packages, excluding excludedPackages, and adding additionalPackages.