Bugfix/inntektsmelding #3807
Merged
Bugfix/inntektsmelding #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… #deploy-test-dolly-backend OpprettInntektsmeldingCommand, and extend SecurityConfig profile support
…vice #deploy-inntektsmelding-service
…getter methods for InntektsmeldingRequest properties #deploy-inntektsmelding-service
…es #deploy-test-dolly-backend #deploy-dolly-backend
… client logging #deploy-test-dolly-backend #deploy-dolly-backend
… for improved code clarity; change foersteFravaersdag type to LocalDate in RsArbeidsforhold #deploy-inntektsmelding-service #deploy-test-dolly-backend #deploy-dolly-backend
…g as LocalDate #deploy-test-dolly-backend #deploy-dolly-backend
…e serialization; add custom Instant deserializer #deploy-inntektsmelding-service
…g as LocalDate #deploy-test-dolly-backend #deploy-dolly-backend
…aersdag #deploy-inntektsmelding-generator-service
…or better null handling #deploy-inntektsmelding-generator-service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of
foersteFravaersdagand enhance logging capabilities. The most important changes include updating thefoersteFravaersdagfield to useStringinstead ofLocalDate, adding a new logger, and modifying the JSON mapper configuration.Improvements to
foersteFravaersdaghandling:apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/inntektsmelding/mapper/InntektsmeldingMappingStrategy.java: Updated the mapping logic to handlefoersteFravaersdagas aStringand convert it toLocalDateif not null.apps/inntektsmelding-generator-service/src/main/java/no/nav/testnav/inntektsmeldinggeneratorservice/provider/adapter/ObjectFactory.java: ChangedfoersteFravaersdagto be created as aStringand parsed toLocalDateif not null.apps/inntektsmelding-generator-service/src/main/java/no/nav/testnav/inntektsmeldinggeneratorservice/provider/dto/ArbeidsforholdDTO.java: Updated thefoersteFravaersdagfield to be aStringinstead ofLocalDate.Logging enhancements:
apps/dolly-backend/src/main/java/no/nav/dolly/bestilling/inntektsmelding/InntektsmeldingConsumer.java: AddedWebClientLoggerto customize theWebClientbuilder for better logging.apps/dolly-backend/src/main/resources/logback-spring.xml: Added a new logger forno.nav.testnav.libs.reactivecore.logging.WebClientLoggerwith theDEBUGlevel.JSON mapper configuration:
apps/inntektsmelding-service/src/main/java/no/nav/registre/testnav/inntektsmeldingservice/config/JsonMapperConfig.java: Enhanced the JSON mapper configuration by addingJavaTimeModule, configuringSerializationFeature.WRITE_DATES_AS_TIMESTAMPSto false, and adding a custom deserializer forInstant. [1] [2]These changes collectively improve the robustness of date handling, enhance logging capabilities, and ensure better JSON serialization and deserialization.