Match behavior between vanilla and fastcore generation of skeleton segments #180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue flagged in #179:
Previously, the vanilla implementation of
_generate_segments
would ignore isolated nodes. That's because it walks from each leaf to the correspond root, and isolated nodes are treated as roots rather than a root that is also a leaf. The implementation of this innavis-fastcore
already returns segments containing only a single node.With this PR, the vanilla implementation of
_generate_segments
will: