Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match behavior between vanilla and fastcore generation of skeleton segments #180

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

schlegelp
Copy link
Collaborator

Addresses issue flagged in #179:

Previously, the vanilla implementation of _generate_segments would ignore isolated nodes. That's because it walks from each leaf to the correspond root, and isolated nodes are treated as roots rather than a root that is also a leaf. The implementation of this in navis-fastcore already returns segments containing only a single node.

With this PR, the vanilla implementation of _generate_segments will:

  • return single node segments
  • return a list of arrays (previously a list of lists)

@schlegelp schlegelp merged commit c8efe9a into master Jan 5, 2025
20 of 21 checks passed
@schlegelp schlegelp deleted the fix_generate_segments branch January 5, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant