-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for body in the reponse before to read it #37
Conversation
Thanks. This seems reasonable. Would you mind adding a test that covers this case? |
Yes, I would like to add a test. Could you give me an example about how to simulate and empty response? I've seen that webfakes is used but I have no experience with it |
|
Tests added, @nealrichardson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion but otherwise this looks good, thank you! Once I merge #38, can you rebase and add a NEWS bullet for this fix?
If the response has no body, write and empty file FIX nealrichardson#35
Co-authored-by: Neal Richardson <[email protected]>
Ready to merge, @nealrichardson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
If the response has no body, write and empty file
FIX #35