Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build_mock_url() for requests with multipart body with string and raw values #40

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Fix build_mock_url() for requests with multipart body with string and raw values #40

merged 7 commits into from
Jun 19, 2024

Conversation

jmaspons
Copy link
Contributor

FIX #39

@jmaspons jmaspons force-pushed the fix_multipart_body branch from c1d84e4 to d446a73 Compare April 29, 2024 16:00
jmaspons added a commit to ropensci/osmapiR that referenced this pull request Apr 29, 2024
@jmaspons
Improve test coverage of functions to edit gps traces
9c10c9f 
Requires nealrichardson/httptest2#40
jmaspons added a commit to ropensci/osmapiR that referenced this pull request Apr 29, 2024
@jmaspons
Revert "Improve test coverage of functions to edit gps traces"
26a7b47 
This reverts commit 9c10c9f which
requires nealrichardson/httptest2#40
@jmaspons jmaspons mentioned this pull request Apr 29, 2024
Closed
@jmaspons jmaspons mentioned this pull request May 23, 2024
Open
nealrichardson
nealrichardson requested changes Jun 17, 2024
View reviewed changes
Copy link
Owner

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

R/build-mock-url.R Outdated Show resolved Hide resolved
R/build-mock-url.R Outdated Show resolved Hide resolved
@jmaspons @nealrichardson
Fix code style
66e2195 
Co-authored-by: Neal Richardson <[email protected]>
@jmaspons
Copy link
Contributor Author

I'm adding tests for the raw data case. For the failing R-CMD-check in windows due to #42, I would add a skip_on_os("windows")

@jmaspons jmaspons requested a review from nealrichardson June 17, 2024 17:44
nealrichardson
nealrichardson reviewed Jun 18, 2024
View reviewed changes
Copy link
Owner

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking another pass at this. A couple of suggestions to hopefully solve the Windows issue (for this PR; we'll have to look again at #42) and finish this up.

tests/testthat/test-capture-requests.R Outdated Show resolved Hide resolved
R/build-mock-url.R Show resolved Hide resolved
@jmaspons jmaspons requested a review from nealrichardson June 18, 2024 19:53
nealrichardson
nealrichardson approved these changes Jun 19, 2024
View reviewed changes
Copy link
Owner

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for doing this!

@nealrichardson nealrichardson changed the title Fix build_mock_url() for requests with multipart body with string values Fix build_mock_url() for requests with multipart body with string and raw values Jun 19, 2024
@nealrichardson nealrichardson merged commit 5b381b9 into nealrichardson:main Jun 19, 2024
10 checks passed
@jmaspons jmaspons deleted the fix_multipart_body branch June 19, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requests with multipart body containing character values fail
2 participants
@jmaspons @nealrichardson