Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid regular expression in "Set Redactor" guide #44

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix invalid regular expression in "Set Redactor" guide #44

merged 2 commits into from
Jul 16, 2024

Conversation

exetico
Copy link
Contributor

@exetico exetico commented Jul 16, 2024

I noticed that the ) are missing in the regex expression, and results in a error once executed.

exetico and others added 2 commits July 16, 2024 10:50
@exetico
Fix invalid regular expression
bfc239b 
The ) are missing in the regex expression, and results in a error once executed.
@nealrichardson
Update redactor.R
c7f8e5b
nealrichardson
nealrichardson approved these changes Jul 16, 2024
View reviewed changes
Copy link
Owner

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you! Since set_redactor.Rd is generated, we also needed to update the source in redactor.R. I just pushed a commit to your branch to do that.

exetico
exetico commented Jul 16, 2024
View reviewed changes
Copy link
Contributor Author

@exetico exetico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding ) to redactor.R is ofc. needed, too. Thanks.

@nealrichardson nealrichardson merged commit 5856ed5 into nealrichardson:main Jul 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exetico @nealrichardson