Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in --action-offline-mode option description #2590

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

sobolevn
Copy link
Contributor

It was like this:

      --action-offline-mode                               If action contents exists, it will not be fetch and pull again. If turn on this,will turn off force pull

@sobolevn sobolevn requested a review from a team as a code owner December 25, 2024 21:45
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (5a80a04) to head (f20fd0f).
Report is 144 commits behind head on master.

Files with missing lines Patch % Lines
cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
+ Coverage   61.56%   68.72%   +7.15%     
==========================================
  Files          53       71      +18     
  Lines        9002    10918    +1916     
==========================================
+ Hits         5542     7503    +1961     
+ Misses       3020     2851     -169     
- Partials      440      564     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Dec 25, 2024

@sobolevn this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Dec 25, 2024
@sobolevn
Copy link
Contributor Author

This failure does not look related:
Снимок экрана 2024-12-26 в 01 27 34

@ChristopherHX ChristopherHX linked an issue Dec 30, 2024 that may be closed by this pull request
Copy link
Contributor

@ChristopherHX ChristopherHX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well.

The codecov change affects me as well, a months ago this check always passed for cmd package as no relevant lines has changed.

cplee: Bypass branch protections?
Fix collecting coverage of cmd package? (I'm not creating a PR for that without ack)

@cplee cplee merged commit 0ca1e18 into nektos:master Dec 31, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work Extra attention is needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

act --help --action-offline-mode is missing a space after ,
3 participants