Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_env_file discard utf8 bom #2638

Merged
merged 8 commits into from
Feb 1, 2025
Merged

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Jan 29, 2025

  • powershell 5 may add the BOM even when explicitly using utf8

  • ask for confirmation in gitea discord

* powershell 5 may add the BOM even when explicitly using utf8
@ChristopherHX ChristopherHX requested a review from a team as a code owner January 29, 2025 14:07
Copy link
Contributor

github-actions bot commented Jan 29, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.02s
✅ REPOSITORY gitleaks yes no 2.43s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 9.01s
✅ REPOSITORY secretlint yes no 1.21s
✅ REPOSITORY trivy-sbom yes no 0.11s
✅ REPOSITORY trufflehog yes no 3.88s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link
Contributor

mergify bot commented Jan 29, 2025

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added the needs-work Extra attention is needed label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.74%. Comparing base (5a80a04) to head (9242fbe).
Report is 157 commits behind head on master.

Files with missing lines Patch % Lines
pkg/container/parse_env_file.go 57.14% 2 Missing and 1 partial ⚠️
pkg/runner/run_context.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2638      +/-   ##
==========================================
+ Coverage   61.56%   68.74%   +7.18%     
==========================================
  Files          53       71      +18     
  Lines        9002    10956    +1954     
==========================================
+ Hits         5542     7532    +1990     
+ Misses       3020     2858     -162     
- Partials      440      566     +126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

mergify bot commented Jan 29, 2025

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot removed the needs-work Extra attention is needed label Jan 29, 2025
Copy link
Contributor

mergify bot commented Feb 1, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Feb 1, 2025

@ChristopherHX this pull request has failed checks 🛠

@mergify mergify bot added needs-work Extra attention is needed and removed needs-work Extra attention is needed labels Feb 1, 2025
@mergify mergify bot merged commit be51601 into master Feb 1, 2025
12 checks passed
@mergify mergify bot deleted the parse_env_file-discard-utf8-bom branch February 1, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants