proposal: NeoFS block storage format #194
Conversation
|
@AliceInHunterland please update accordingly, this is not likely can be reviewed with any useful suggestions from other coredevs since we know little about neofs, please just follow roman's suggestion |
AliceInHunterland
force-pushed
the
neofs-blocks
branch
from
1c6106c to
674a1c2
Compare
AliceInHunterland
force-pushed
the
neofs-blocks
branch
2 times, most recently
from
1231891 to
6c12fbe
Compare
neofs-blocks.mediawiki
Outdated
| An [https://rest.fs.neo.org/v1/objects/3RCdP3ZubyKyo8qFeo7EJPryidTZaGCMdUjqFJaaEKBV/by_id/Fu7yQzspvLJwSGJNK64xeeyMdWXtU5B5b1es6KSxUag1 example] | ||
| of a block object is as follows: | ||
| <pre> | ||
| ID: Fu7yQzspvLJwSGJNK64xeeyMdWXtU5B5b1es6KSxUag1 | ||
| CID: 3RCdP3ZubyKyo8qFeo7EJPryidTZaGCMdUjqFJaaEKBV | ||
| Owner: NVvY1FF67XJ2GTVhy9FqiZGC4jEQtvjmHt |
There was a problem hiding this comment.
Is it correct to attach object link as an example? This object/container may be removed in future whereas we expect NEP to be consistent. @roman-khimov?
There was a problem hiding this comment.
Example can be a proper example with this data if needed. It doesn't imply any of the IDs are relevant for mainnet or whatever else.
AliceInHunterland
force-pushed
the
neofs-blocks
branch
from
6c12fbe to
bf44b35
Compare
AnnaShaleva
force-pushed
the
neofs-blocks
branch
3 times, most recently
from
b02aabe to
b795db3
Compare
AnnaShaleva
requested review from
shargon,
cschuchardt88,
Jim8y,
vncoelho and
Wi1l-B0t
|
@roman-khimov, let's review one more time. |
neofs-blocks.mediawiki
Outdated
| NEP: TBD | ||
| Title: NeoFS block storage format | ||
| Author: Ekaterina Pavlova <[email protected]> | ||
| Type: Standard |
neofs-blocks.mediawiki
Outdated
| ==Abstract== | ||
|
|
||
| This proposal outlines the specification for storing Neo blockchain blocks within | ||
| the NeoFS container. |
| These attributes are stored as NeoFS object metadata; the list of attributes MAY be extended. | ||
| The object MAY include additional data after the block. | ||
|
|
||
| An example of a [https://rest.fs.neo.org/v1/objects/3RCdP3ZubyKyo8qFeo7EJPryidTZaGCMdUjqFJaaEKBV/by_id/Fu7yQzspvLJwSGJNK64xeeyMdWXtU5B5b1es6KSxUag1 block object]: |
There was a problem hiding this comment.
Maybe use Test cases section for it?
neofs-blocks.mediawiki
Outdated
| Blocks stored in NeoFS and those synchronized via P2P both use the standard Neo block | ||
| serialization format, ensuring compatibility across different synchronization methods. | ||
| The NeoFS container serves as verified storage for downloading blocks. Blocks should be | ||
| searched one by one directly by block attribute. |
There was a problem hiding this comment.
It'd be dog slow with a per-object search, GE searches should be used. It also better be described in terms of NeoFS API (https://github.com/nspcc-dev/neofs-api/blob/master/object/service.proto).
Signed-off-by: Ekaterina Pavlova <[email protected]>
AnnaShaleva
force-pushed
the
neofs-blocks
branch
from
b795db3 to
6b50aeb
Compare
|
LGTM. I prefer to approve the general logic as long as its correct and complete, then polish the format later. |
| |- | ||
| | BlockTime || Millisecond-precision timestamp when the block was created. | ||
| |- | ||
| | Timestamp || Second-precision timestamp when the block was uploaded. |
There was a problem hiding this comment.
What is the difference between Timestamp and BlockTime?
Maybe it would be better to rename Timestamp to UploadTime.
There was a problem hiding this comment.
Timestamp just follows well-known NeoFS object attribute:
https://github.com/nspcc-dev/neofs-api/blob/b7548cfb16426256f0a92c6d70a3ec794a6facb0/object/types.proto#L245
(maybe it's worth mentioning this in the document)
| | BlockTime || Millisecond-precision timestamp when the block was created. | ||
| |- | ||
| | Timestamp || Second-precision timestamp when the block was uploaded. |
There was a problem hiding this comment.
| | BlockTime || Millisecond-precision timestamp when the block was created. | |
| |- | |
| | Timestamp || Second-precision timestamp when the block was uploaded. | |
| | BlockTime || Millisecond-precision unix timestamp when the block was created. | |
| |- | |
| | Timestamp || Second-precision unix timestamp when the block was uploaded. |
timestamp is unix timestamp ?
No description provided.