-
Notifications
You must be signed in to change notification settings - Fork 24
Shorten menu links + cleanup #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @stefano-ottolenghi for taking upon you to make the dropdown shorter. I like brevity, but it is not completely straightforward as I've explained in my comments. And if we cut some Neo4js out, it may end up messier than to begin with.
Also, do we know that the size of the dropdown is a problem for a lot of users? I have never thought of it before, but I do have a large screen.
Those are my two cents.
<li><a href="/docs/dataflow-bigquery/" class="project-link">BigQuery to Neo4j</a></li> | ||
<li><a href="/docs/dataflow-google-cloud/" class="project-link">Google Cloud to Neo4j</a></li> | ||
<li><a href="/docs/cdc/current/" class="project-link">Change Data Capture (CDC)</a></li> | ||
<li><a href="/docs/spark/current/" class="project-link">Apache Spark</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment for all the connectors. I'm not sure if we can use just the name of the platform without having Neo4j Connector in the title. It becomes a potential copyright issue.
<li><a href="{{#with (docs-driver-manual-url page 'javascript-manual')}}{{{this}}}{{/with}}" class="project-link">JavaScript</a></li> | ||
<li><a href="{{#with (docs-driver-manual-url page 'dotnet-manual')}}{{{this}}}{{/with}}" class="project-link">.Net</a></li> | ||
<li><a href="/docs/graphql-manual/current/" class="project-link">GraphQL</a></li> | ||
<li><a href="/docs/nvl/current/" class="project-link">Visualization Library</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite often referred to as NVL so if we omit Neo4j it becomes just VL and that's not right.
Before

After
