Merge pull request #33 from neo4j-labs/feat/testing-new-driver

Checking PR #31 on our develop
neo4j-labs · Jul 11, 2024 · ca1fb29 · ca1fb29
2 parents f78e5c9 + 2215fc0
commit ca1fb29
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/rdflib_neo4j/Neo4jStore.py b/rdflib_neo4j/Neo4jStore.py
@@ -23,6 +23,8 @@ def __init__(self, config: Neo4jStoreConfig, neo4j_driver: Driver = None):
         self.driver = neo4j_driver
         self.session = None
         self.config = config
+
+        # Check that either driver or credentials are provided
         if not neo4j_driver:
             check_auth_data(config.auth_data)
         elif config.auth_data:

diff --git a/rdflib_neo4j/config/Neo4jStoreConfig.py b/rdflib_neo4j/config/Neo4jStoreConfig.py
@@ -5,8 +5,6 @@
     PrefixNotFoundException,
     HANDLE_VOCAB_URI_STRATEGY, HANDLE_MULTIVAL_STRATEGY
 )
-from rdflib_neo4j.config.utils import check_auth_data
-
 
 class Neo4jStoreConfig:
     """

diff --git a/test/integration/store_initialization_test.py b/test/integration/store_initialization_test.py
@@ -8,7 +8,7 @@
 
 
 def test_initialize_store_with_credentials(neo4j_connection_parameters, neo4j_driver):
-
+    """ Test that we can initialize a store by passing the credentials config. """
     auth_data = neo4j_connection_parameters
 
     config = Neo4jStoreConfig(auth_data=auth_data,
@@ -27,7 +27,7 @@ def test_initialize_store_with_credentials(neo4j_connection_parameters, neo4j_dr
 
 
 def test_initialize_store_with_driver(neo4j_driver):
-
+    """ Test that we can initialize a store with a driver. """
     config = Neo4jStoreConfig(auth_data=None,
                               custom_prefixes={},
                               custom_mappings=[],
@@ -44,7 +44,7 @@ def test_initialize_store_with_driver(neo4j_driver):
 
 
 def test_initialize_with_both_credentials_and_driver_should_fail(neo4j_connection_parameters, neo4j_driver):
-
+    """ Test that we can't initialize a store with both credentials and a driver. """
     config = Neo4jStoreConfig(auth_data=neo4j_connection_parameters,
                               custom_prefixes={},
                               custom_mappings=[],