feat(logging): add support for System.Logger and deprecate Logging #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/logging
branch
from
baa7c5c to
465af11
Compare
injectives
changed the title
injectives
force-pushed
the
feature/logging
branch
8 times, most recently
from
e1ccb17 to
c64fa00
Compare
BREAKING CHANGE: the default driver logging implementation has been changed from `Logging#none()` to `Logging.systemLogging()`. The logging abstraction has been deprecated in favour of the `System.Logger`. Specifically, this applies to the following:: - `org.neo4j.driver.Logging` - `org.neo4j.driver.Logger` - `org.neo4j.driver.Config.ConfigBuilder#withLogging(Logging)` - `org.neo4j.driver.Config#logging()` Once the logging abstraction is deleted, the driver is expected to use the `System.Logger` only.
injectives
force-pushed
the
feature/logging
branch
from
c64fa00 to
deb675d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the default driver logging implementation has been changed from
Logging#none()toLogging.systemLogging().The logging abstraction has been deprecated in favour of the
System.Logger. Specifically, this applies to the following::org.neo4j.driver.Loggingorg.neo4j.driver.Loggerorg.neo4j.driver.Config.ConfigBuilder#withLogging(Logging)org.neo4j.driver.Config#logging()Once the logging abstraction is deleted, the driver is expected to use the
System.Loggeronly.