Skip to content

Fix inconsistent typing of duration properties #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 10, 2025

Conversation

MaxAake
Copy link
Contributor

@MaxAake MaxAake commented Mar 21, 2025

When creating a Duration the seconds and nanoseconds will be converted to Integers, no matter if provided with Integers, Numbers, or BigInts. This is awkward and requires special handling by users

@MaxAake MaxAake changed the base branch from 5.0 to 6.x April 7, 2025 07:40
@MaxAake MaxAake changed the base branch from 6.x to 5.0 April 7, 2025 07:46
@MaxAake MaxAake changed the base branch from 5.0 to 6.x May 14, 2025 12:57
@MaxAake MaxAake changed the base branch from 6.x to 5.0 May 14, 2025 12:59
@MaxAake MaxAake changed the base branch from 5.0 to 6.x May 20, 2025 06:47
@MaxAake MaxAake force-pushed the fix-integer-conversion-with-configs branch from 967c612 to f433d5c Compare May 30, 2025 06:38
@MaxAake MaxAake requested a review from robsdedude June 9, 2025 08:17
Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit: the fact that your last commits changed behavior while all tests stayed the same (and passed before and still do) suggests that test coverage could be improved :)

@MaxAake MaxAake merged commit 5d8916b into 6.x Jun 10, 2025
37 checks passed
@MaxAake MaxAake deleted the fix-integer-conversion-with-configs branch June 10, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants