Skip to content

Better error messages for convenience constructors #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2025

Conversation

adamnsch
Copy link
Collaborator

@adamnsch adamnsch commented May 23, 2025

Thank you for your contribution to the Graph Visualization for Python project by Neo4j.

Before submitting this PR, please read Contributing to the Neo4j Ecosystem.

Make sure:

  • You signed the Neo4j CLA (Contributor License Agreement) so that we are allowed to ship your code in our library
  • Your contribution is covered by tests

Checklist:

  • from_dfs
  • from_gds
  • from_neo4j
  • from_gql_create

@adamnsch adamnsch force-pushed the better-integration-errors branch from a0863f7 to 3fe32ff Compare May 23, 2025 13:28
@adamnsch adamnsch changed the title WIP: Better error messages for convenience constructors Better error messages for convenience constructors May 23, 2025
@adamnsch adamnsch marked this pull request as ready for review May 23, 2025 14:24
Copy link
Collaborator

@FlorentinD FlorentinD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it :)

just adding a change log entry now?

@adamnsch
Copy link
Collaborator Author

I like it :)

just adding a change log entry now?

Still forgetting about that 🙈

@adamnsch adamnsch force-pushed the better-integration-errors branch from 23a530e to f828075 Compare May 27, 2025 08:42
@adamnsch adamnsch force-pushed the better-integration-errors branch from f828075 to f5506dc Compare May 27, 2025 09:03
@adamnsch adamnsch merged commit d241095 into main May 27, 2025
4 checks passed
@adamnsch adamnsch deleted the better-integration-errors branch May 27, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants