Skip to content

gds/rel properties #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gds/rel properties #173

wants to merge 3 commits into from
+116 −86

Conversation

FlorentinD
Copy link
Collaborator

@FlorentinD FlorentinD commented May 28, 2025 •
edited
Loading

No description provided.

adamnsch
adamnsch reviewed May 30, 2025
View reviewed changes
Copy link
Collaborator

@adamnsch adamnsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But I think we should still provide the opportunity to not fetch any properties. I would add a relationship_properties: Optional[list[str]] = None argument. None means we fetch everything, and [] means we fetch nothing

@adamnsch
Copy link
Collaborator

Nice! But I think we should still provide the opportunity to not fetch any properties. I would add a relationship_properties: Optional[list[str]] = None argument. None means we fetch everything, and [] means we fetch nothing

I suppose GDS only supports having one rel prop, so could even be a boolean 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamnsch adamnsch adamnsch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorentinD @adamnsch