♻️ replace deprecated per_second with seconds_per_request function
#616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-limiting middleware
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on making your first Pull Request and thanks for taking the time to improve Websurfx! ❤️!
Say hello by joining the conversation in our Discord
neon-mmd
changed the title
per_second with seconds_per_request function
neon-mmd
requested review from
jfvillablanca,
spencerjibz,
alamin655 and
neon-mmd
neon-mmd
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates rate-limiting middleware to use the new seconds_per_request function and removes usage of the deprecated per_second function.
Why is this change important?
Using deprecated functions can lead to compatibility issues with future updates of the middleware or framework. By adopting seconds_per_request, you're ensuring that your code remains compatible with upcoming versions, reducing the risk of breaking changes in the future.
Related issues
Closes #614