Use 'vmv1' for neonvm API import everywhere #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within neonvm-controller, we were consistently using 'vmv1' to refer to the ".../apis/neonvm/v1" import, but elsewhere we were using 'vmapi' instead. 'vmv1' is closer to the typical kubernetes imports like corev1 and metav1, even if it doesn't exactly match the import path.
No changes to the coverage.
HTML Report |
Omrigan
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within neonvm-controller, we're consistently using
vmv1to refer to the.../apis/neonvm/v1import, but elsewhere we're usingvmapiinstead.vmv1is closer to the typical kubernetes imports likecorev1andmetav1, even if it doesn't exactly match the import path.Notes for review: Low priority, been on my todo list for a while and I figured that #995 was a good enough excuse to do it. Also, this is probably a good candidate to add to
.git-blame-ignore-revsafter merging, because otherwise it's a lot of noise.