Backfill created updated closed #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaiBojin
approved these changes
Apr 18, 2025
| }).filter(pr => Boolean(pr)) as Array<Pick<NeonProject, 'projectId' | 'projectNumber' | 'updatedAtFieldId' | 'createdAtFieldId' | 'closedAtFieldId'>>; | ||
| console.log(config) | ||
|
|
||
| export const backfill_created_updated_deleted = async (octokit: ProbotOctokit) => { |
There was a problem hiding this comment.
splitting this out in multiple functions would make it easier to understand the intent behind the code :)
| while (pageInfo.hasNextPage) { | ||
| try { | ||
| const res: { | ||
| search: { |
There was a problem hiding this comment.
nit: I would move this to a separate file (if possible), as it would make it easier to lint and edit/maintain long term
| logger('error', e) | ||
| } | ||
| } | ||
| logger('info', `Set created at for issue #${issue.number} ${issue.title} in project ${project.projectId} with value ${createdAtFieldDesiredValue}`) |
There was a problem hiding this comment.
nit: might be confusing in dry-run mode / consider two log lines:
- attempting to do X (this line)
- did X / did not do X in dry-run
There was a problem hiding this comment.
yeah, I agree. It's how i did that in other places, so I'll keep it this way for now
| } catch(e) { | ||
| logger('error', e) | ||
| } | ||
| } |
This was referenced Apr 22, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.