Skip to content

Bump probot version #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2025
Merged

Bump probot version #70

merged 6 commits into from
Apr 23, 2025

Conversation

seymourisdead
Copy link
Member

@seymourisdead seymourisdead commented Apr 22, 2025

this is a prerequisite for a next automation to improve working with subissues within projects

using beta is fine-ish as it's mostly about new typings and they are close to releasing it

@seymourisdead
Copy link
Member Author

seymourisdead commented Apr 22, 2025

--(need to fix tests first)--

@@ -2,1043 +2,854 @@
# yarn lockfile v1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I migrate this thing to latest Yarn? Pretty plz

Comment on lines 2 to +3
import issueWithParents from "./fixtures/issueWithParents.json";
import { describe, expect, test, beforeEach } from 'vitest'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I also add a formatter? (noticed the ' and " quotes being used :D)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long

@@ -16,7 +16,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v2
with:
node-version: '16'
node-version: '22'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly better:

Suggested change
node-version: '22'
node-version-file: '.node-version'

And put 22.15.0 in .node-version in repo root

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, can we use it in package.json too?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tools like fnm can read the engines field from package.json (fun fact, I added support for it in Schniz/fnm#839) but setup-node cannot.

Copy link

@amitdahan amitdahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

added suggestions

@seymourisdead
Copy link
Member Author

@amitdahan I plan to add one more automation that will hopefully help us use subissues everywhere and migrate from task lists. Let's discuss maintanence after that?

@seymourisdead seymourisdead merged commit 85d4547 into main Apr 23, 2025
2 checks passed
@seymourisdead seymourisdead deleted the bump-probot-version branch April 23, 2025 12:36
@amitdahan
Copy link

@amitdahan I plan to add one more automation that will hopefully help us use subissues everywhere and migrate from task lists. Let's discuss maintanence after that?

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants