-
Notifications
You must be signed in to change notification settings - Fork 2
Bump probot version #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
--(need to fix tests first)-- |
@@ -2,1043 +2,854 @@ | |||
# yarn lockfile v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I migrate this thing to latest Yarn? Pretty plz
import issueWithParents from "./fixtures/issueWithParents.json"; | ||
import { describe, expect, test, beforeEach } from 'vitest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I also add a formatter? (noticed the '
and "
quotes being used :D)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So long
@@ -16,7 +16,7 @@ jobs: | |||
- name: Use Node.js | |||
uses: actions/setup-node@v2 | |||
with: | |||
node-version: '16' | |||
node-version: '22' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly better:
node-version: '22' | |
node-version-file: '.node-version' |
And put 22.15.0
in .node-version
in repo root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, can we use it in package.json too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tools like fnm
can read the engines
field from package.json
(fun fact, I added support for it in Schniz/fnm#839) but setup-node
cannot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
added suggestions
@amitdahan I plan to add one more automation that will hopefully help us use subissues everywhere and migrate from task lists. Let's discuss maintanence after that? |
LGTM |
this is a prerequisite for a next automation to improve working with subissues within projects
using beta is fine-ish as it's mostly about new typings and they are close to releasing it