-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conrad/teach proxy compute tls #10717
Draft
conradludgate
wants to merge
12
commits into
main
Choose a base branch
from
conrad/teach-proxy-compute-tls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…een host_addr and host_name control plane returns us a socket address, but we need a hostname for TLS
7425 tests run: 7067 passed, 0 failed, 358 skipped (full report)Flaky tests (2)Postgres 16
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
762dafc at 2025-02-07T17:51:21.910Z :recycle: |
…te between host_addr and host_name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/neondatabase/cloud/issues/23008
For TLS between proxy and compute, we are using an internally provisioned CA to sign the compute certificates. This change ensures that proxy will load them from a supplied env var pointing to the correct file - this file and env var will be configured later, using a kubernetes secret.
To use TLS, we need a hostname. For now, we decided to use the kubernetes service name as it seemed most appropriate - eg
compute-id.default.svc.cluster.local
. (see https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/). This is very neon specific and would break if we ever decided to use different namespaces for each endpoint. Since control-plane is what creates the service, we should update the wake compute response appropriately, but I think this is a suitable first passCompute doesn't offer TLS yet, so I have it set to "Prefer", which allows TLS but is fine if it's not enabled - this allows us to roll out. This should be configurable.