Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: reduce default compaction_upper_limit to 20 #10889

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Feb 19, 2025

Problem

We've seen the previous default of 50 cause OOMs. Compacting many L0 layers at once now has limited benefit, since the cost is mostly linear anyway. This is already being reduced to 20 in production settings.

Summary of changes

Reduce DEFAULT_COMPACTION_UPPER_LIMIT to 20.

Once released, let's remove the config overrides.

Copy link

7546 tests run: 7174 passed, 0 failed, 372 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 32.9% (8620 of 26193 functions)
  • lines: 48.9% (72727 of 148858 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
895edd0 at 2025-02-19T12:45:13.907Z :recycle:

@erikgrinaker erikgrinaker added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 0453eaf Feb 19, 2025
92 checks passed
@erikgrinaker erikgrinaker deleted the erik/compaction-upper-limit branch February 19, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants