Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs: remove unnecessary regex in pprof::symbolize #10893

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

erikgrinaker
Copy link
Contributor

pprof::symbolize() used a regex to strip the Rust monomorphization suffix from generic methods. However, the backtrace crate can do this itself if formatted with the :# flag.

Also tighten up the code a bit.

Copy link

7546 tests run: 7173 passed, 0 failed, 373 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 32.9% (8619 of 26193 functions)
  • lines: 48.9% (72748 of 148856 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
147c172 at 2025-02-19T14:35:59.786Z :recycle:

@erikgrinaker erikgrinaker added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 0b3db74 Feb 19, 2025
90 checks passed
@erikgrinaker erikgrinaker deleted the erik/pprof-regex branch February 19, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants