-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storcon: use the SchedulingPolicy enum in SafekeeperPersistence #10897
base: main
Are you sure you want to change the base?
Conversation
7557 tests run: 7184 passed, 0 failed, 373 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
a1f4091 at 2025-02-20T16:53:56.751Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we implement FromSql directly on SkSchedulingPolicy to avoid messing with wrapper type?
Also please rebase/merge so for easier review, it seems to have code from prev PR.
Both |
7d4c308
to
a1f4091
Compare
I've added a doc comment to explain the reason why we have a wrapper. |
Hang on, why SkSchedulingPolicy is even in pageserver_api crate? Let's just move it straightly to storcon. Safekeepers themselves don't need to be aware how they are scheduled, even more pageservers. |
We don't want to serialize to/from string all the time, so use
SchedulingPolicy
inSafekeeperPersistence
via the use of a wrapper.Stacked atop #10891