Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download extension if it does not exist on the filesystem #11315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tristan957
Copy link
Member

Previously we attempted to download all extensions in CREATE EXTENSION statements. Extensions like pg_stat_statements and neon are not remote extensions, but still we were requesting them when skip_pg_catalog_updates was set to false.

Fixes: #11127

@tristan957 tristan957 requested a review from a team as a code owner March 19, 2025 17:56
@tristan957 tristan957 requested review from hlinnaka and thesuhas March 19, 2025 17:56
@tristan957 tristan957 changed the title Download extension if does not exist on the filesystem Download extension if it does not exist on the filesystem Mar 19, 2025
Copy link

If this PR added a GUC in the Postgres fork or neon extension,
please regenerate the Postgres settings in the cloud repo:

make NEON_WORKDIR=path/to/neon/checkout \
  -C goapp/internal/shareddomain/postgres generate

If you're an external contributor, a Neon employee will assist in
making sure this step is done.

@tristan957
Copy link
Member Author

I'd love to add a test for this, but we would need to add some more metrics. compute_ctl_remote_ext_requests_total doesn't cut it because it is collected to deep in the stack. @ololobus I think when we add axum metrics, that will be a good time to add a test for this.

Copy link

github-actions bot commented Mar 19, 2025

8041 tests run: 7658 passed, 0 failed, 383 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 32.3% (8730 of 27067 functions)
  • lines: 48.5% (75319 of 155338 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6a14b07 at 2025-03-31T23:20:59.123Z :recycle:

@tristan957 tristan957 force-pushed the tristan957/download-on-failure branch from 736d02f to 2171be1 Compare March 19, 2025 19:46
@ololobus
Copy link
Member

@ololobus I think when we add axum metrics, that will be a good time to add a test for this.

Yeah, I think we could add axum / compute_ctl http server metrics and that will cover this case

@tristan957 tristan957 force-pushed the tristan957/download-on-failure branch from 2171be1 to bb25171 Compare March 31, 2025 21:44
Previously we attempted to download all extensions in CREATE EXTENSION
statements. Extensions like pg_stat_statements and neon are not remote
extensions, but still we were requesting them when
skip_pg_catalog_updates was set to false.

Signed-off-by: Tristan Partin <tristan@neon.tech>
@tristan957 tristan957 force-pushed the tristan957/download-on-failure branch from bb25171 to 6a14b07 Compare March 31, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't make remote extension requests unconditionally in CREATE EXTENSION statements
2 participants