WIP Re-add Neos7 Flicker plugin for testing the fusion plugin #190
Conversation
| options: | ||
| # todo weren't plugin views removed? https://github.com/neos/neos-development-collection/pull/4330 | ||
| 'pluginViews': | ||
| 'UserFeed': | ||
| label: 'Neos.Demo:NodeTypes.Content.Flickr:options.pluginViews.userFeed' | ||
| controllerActions: | ||
| 'Neos\Demo\Controller\FlickrController': ['userStream'] |
There was a problem hiding this comment.
pluginViews? Yeah we removed those. Which technically means we broke this plugin, because people said no one ever uses plugin views 🙈
| <li class="pull-left"> | ||
| <f:render partial="Flickr/Photo" arguments="{photo: photo}" /> | ||
| <p> | ||
| <f:link.action action="userStream" arguments="{userId: photo.author_id}">Show more photos by "{photo.author}"</f:link.action> |
There was a problem hiding this comment.
that link cannot be resolved:
Could not resolve a route and its corresponding URI for the given parameters. This may be due to referring to a not existing package / controller / action while building a link or URI. Refer to log and check the backtrace for more details
arguments:
{
"node": "live__eyJsYW5ndWFnZSI6ImVuX1VTIn0=__336d96a5-b6c6-7d81-685f-89d32c37756e",
"@package": "Neos.Neos",
"@controller": "Frontend\\Node",
"@action": "show",
"@format": "html",
"--neos_demo-content_flickr": {
"@package": "neos.demo",
"@controller": "flickr",
"@action": "userstream",
"@format": "html",
"userId": "187194180@N06"
}
}There was a problem hiding this comment.
Is "node" in this a correct representation for a frontend node in a route?
The rest seems fine to me...
There was a problem hiding this comment.
ah checked out the actual 7.3 demo and it seems the way this plugin was engineered it somehow realied on plugin views .. thats probably why it wont work?
The "master" page
structure
"plugin" page
There was a problem hiding this comment.
could be, but in theory it should just be able to link to the page and switch to this action then. like views were never needed for multiple actions, just if you wanted to split those actions to different pages.
There was a problem hiding this comment.
i dont understand ... not even linking to the same page works:
public function tagStreamAction()
{
return $this->uriBuilder->uriFor('tagStream');There was a problem hiding this comment.
oh wait a second ... i think i answered
Is "node" in this a correct representation for a frontend node in a route?
to quickly in my head node is usually a node address object i think. And yess 💯 now the links resolve :D
There was a problem hiding this comment.
This should not be merged but as we have no real test otherwise if the plugins work and if they should be part of 9.0 we have to test them $somehow.
I used the NeosDemo 7.3 Flicker plugin under the assumption that it should work.