Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neos 9.0 Sub-request on Neos.Neos Frontend page broken #4909

Open
mhsdesign opened this issue Feb 22, 2024 · 0 comments · May be fixed by #5304
Open

Neos 9.0 Sub-request on Neos.Neos Frontend page broken #4909

mhsdesign opened this issue Feb 22, 2024 · 0 comments · May be fixed by #5304

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Feb 22, 2024

Routing in plugins like described here neos/Neos.Demo#190 (comment) is currently broken.

The EventSourcedFrontendNodeRoutePartHandler expects a NodeAdress instance and not a serialized string:

Fix:

if (!$nodeAddress instanceof NodeAddress) {
    $nodeAddress = NodeAddressFactory::create($this->contentRepositoryRegistry->get($currentRequestSiteDetectionResult->contentRepositoryId))
        ->createFromUriString($nodeAddress);
}

But the real question is why was it a string in the first place? I fear because of this weird thing?

With this fix the Neos.Neos:Plugin works as described here neos/Neos.Demo#190

Things i tested in the controller (we should ad an behat test for each):

  • forward (content of other action)
  • throwStatus (500 will be upmerged and plugin will show text inside: 500 Internal Server Error
  • redirect (uri will change)
  • set arbitrary header x-mhs: foobar
  • build uri to another action (navigation)
  • render fluid view
  • render string
@ahaeslich ahaeslich added the 9.0 label Apr 10, 2024
@mhsdesign mhsdesign added the Bug label May 24, 2024
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this issue Oct 20, 2024
> Could not resolve a route and its corresponding URI for the given parameters.
@mhsdesign mhsdesign linked a pull request Oct 20, 2024 that will close this issue
6 tasks
@mhsdesign mhsdesign moved this to Prioritized 🔥 in Neos 9.0 Release Board Oct 21, 2024
@mhsdesign mhsdesign moved this from Prioritized 🔥 to In Progress 🚧 in Neos 9.0 Release Board Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

2 participants