Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Access isNil function from Helper function to apply selected image to property #5140

Conversation

crydotsnake
Copy link
Member

@crydotsnake crydotsnake commented Jun 13, 2024

Upgrade instructions

None

Review instructions

Follow-up to: #5117

With the latest Bugfix release of Neos 8.3.14 currently when selecting an image from the media browser it not will be applyied to the image property as the IsNil function has to be accessed inside of the Helper function.

NeosCMS.isNil()

In this case, leads to an unresolved function or method.

Before

before.mov

After

after.mov

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@crydotsnake crydotsnake changed the title BUGFIX: Access isNil function from Helper function to apply image to property BUGFIX: Access isNil function from Helper function to apply selected image to property Jun 13, 2024
@kitsunet
Copy link
Member

Lovely with the video, thanks a lot <3

Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense looking at the codebase.

@kitsunet kitsunet merged commit fc405ec into neos:8.3 Jun 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants