TASK: Introduce full behat test for FrontendNodeController #5305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
commented
Oct 21, 2024
Neos.Neos/Tests/Behavior/Features/Bootstrap/DispatcherTrait.php
Outdated
Show resolved
Hide resolved
mhsdesign
commented
Nov 2, 2024
mhsdesign
commented
Nov 2, 2024
|
see above, deprecations instead of removals, rest is nice, although not sure why this is urgent/important atm? |
|
Otherwise the pile im building upon this gets too large and i wanted to have that merged since the sprint. Thanks :) (see #5304) |
bwaidelich
reviewed
Nov 12, 2024
| @@ -52,6 +52,9 @@ public static function tryFromFilePath(string $filePath): self | |||
| return self::fromFilePath($filePath); | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated with Neos 9, remove me :) | |||
There was a problem hiding this comment.
why, what will it be replaced with?
There was a problem hiding this comment.
this is not api anymore with Neos 9.0 and you can make it yourself ... there is just no need for this as we dont use it for the normal fusion view neither. The source code collection should not deal with this logic and be flow package aware.
bwaidelich
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Predecessor for #5304
Fixes parts of #4933
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions