Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Document that scatter does NOT move fallbacks! #5388

Merged

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Dec 1, 2024

Cherrypicked from bernhards original change in https://github.com/neos/neos-development-collection/pull/4994/files#diff-4a3a69f0f68fa88f95e6a757f42dee32aa9a14a34ed99433e09a6950b5be0ce1

Followup to using scatter now: neos/neos-ui#3876

GOTO a page ("Multiple columns") in EN_US, which only has fallbacks and no content variants.
Move an element in EN_US with the new scatter content behaviour ("Why, Mary Ann..." below "Hand it over here...")
The element is only moved in EN_US and NOT moved in EN_UK.

In Neos 8.3 they were moved, as long it was just a fallback:

image

If you previously changed the text in 8.3 (create a variant in EN_UK) the move in US is not affected in UK.

Neos 9.0 makes that behaviour more consistent. In case the variants should also be moved gatherSpecializations should be configured:

'Neos.Neos:Content':
  options:
    moveNodeStrategy: gatherSpecializations

there is no exact behaviour like Neos 8.3 in the core.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign merged commit ac7a598 into neos:9.0 Jan 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant