Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Avoid that doctrine:migrationgenerate drops pure dbal tables #5394

Open
wants to merge 2 commits into
base: 9.0
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

Resolves: #5391

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign
Copy link
Member Author

As i feared the Neos.Neos tests fail because we dont tear down all tables now automagically.

This is because we have to respect the ignore table list in the teardown of behat: neos/behat#37

001 Scenario: Nodes on user workspace have been created                      # Features/AssetUsage/01-NodeCreation/01-CreateNodeAggregateWithNode_WithoutDimensions.feature:64
      Then I expect the AssetUsageService to have the following AssetUsages: # Features/AssetUsage/01-NodeCreation/01-CreateNodeAggregateWithNode_WithoutDimensions.feature:74
        Not all given asset usages where found.
        Failed asserting that an array is empty.

Locally i got 123 failing test.

Following dbal only repos are affected:

  • WorkspaceAndRoleRepository
  • AssetUsageRepository

I worked around this now by explicitly pruning the repositories again in the tests ... its not pretty but maybe the best.

Its probably legit that the FlowEntitiesTrait does NOT touch these tables anymore as they are dbal pure and not flow entities ^^

@mhsdesign mhsdesign marked this pull request as ready for review December 10, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Current beta tries to delete DB-tables
2 participants