New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Asset that `SetNodeProperties` is not handled empty #5396

Open

mhsdesign wants to merge 1 commit into neos:9.0 from mhsdesign:bugfix/fail-early-if-set-properties-is-empty

Member

mhsdesign commented Dec 5, 2024

see #5357 (comment)

currently SetNodeProperties with 0 properties attempts to publish 0 events which throws an error since #5357

Writable events must contain at least one event

Instead we throw an exception in SetNodeProperties. We DONT expect PropertyValuesToWrite to be empty as suggested: #5357 (comment)

As there is code using PropertyValuesToWrite as builder and

Upgrade instructions

Review instructions

Checklist

Code follows the PSR-2 coding style
Tests have been created, run and adjusted as needed
The PR is created against the lowest maintained branch
Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
Reviewer - The first section explains the change briefly for change-logs
Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions


          BUGFIX: Asset that SetNodeProperties is not handled empty

455e12f

github-actions bot added Bug 9.0 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels