-
Notifications
You must be signed in to change notification settings - Fork 16
fix: mark '|'
as word
#147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
de54d4f
to
f860015
Compare
@justinmk this removes all but two errors (one of which is trivial to fix on our side) but leaves a bunch of (~70) (The biggest issue -- which is a huge issue -- is that Vim docs use literal backticks all over the place, which is an unresolvable conflict with (Possibly ignoring all of |
3a08e12
to
7f2d856
Compare
I haven't looked much at the usr_ docs but I haven't seen these widespread problems... our docs gen asserts zero errors
for "literal backticks" that seems fine. how many cases are there of that actually |
No, it only asserts zero _generate
About 8 files (after my nvim PR is merged), some of those with potentially many occurrences. So it's not a minor effort (and risk of reintroducing them when we port vim patches, although current patches are unlikely to involve marks). |
e804078
to
0fcd398
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Windows failure parsing the corpus is consistent; my guess is that some regex in the grammar are not Windows-safe. Since I can't deal with that and it looks unrelated to the changes here, I'm disabling the Windows job. Someone with access to Windows and tree-sitter needs to investigate, fix, and re-enable; that someone is not me, but they can ping me if they need help. |
How? |
I don't know, that's the point. But we've had issues involving that on other parsers in the past, the errors seem to revolve around |
Could also be an issue with the |
No description provided.