Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attachLifecycleWithActions in ModuleProxy #34

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Add attachLifecycleWithActions in ModuleProxy #34

merged 5 commits into from
Aug 1, 2024

Conversation

ianlauyin
Copy link
Contributor

  • Created a new method in ModuleProxy to avoid circular dependency between module and component.

@dionshihk
Copy link
Collaborator

Thanks for the PR.
After reviewing, my suggestion is to update the existing attachLifecycle method with extra actions props, which is compatible in props typing.

@dionshihk dionshihk merged commit 9cccfc4 into neowu:master Aug 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianlauyin @dionshihk