Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite channel actor state tlc operations #341

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Nov 25, 2024

Fixes #245
Fixes #305

@chenyukang chenyukang marked this pull request as draft November 25, 2024 11:59
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 54.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 47.81%. Comparing base (a5cde07) to head (8870a4d).

Files with missing lines Patch % Lines
src/fiber/network.rs 58.97% 16 Missing ⚠️
src/fiber/history.rs 40.00% 3 Missing ⚠️
src/cch/actor.rs 0.00% 2 Missing ⚠️
src/fiber/types.rs 66.66% 1 Missing ⚠️
src/rpc/channel.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
+ Coverage   47.41%   47.81%   +0.40%     
==========================================
  Files          47       47              
  Lines       28864    29085     +221     
==========================================
+ Hits        13686    13908     +222     
+ Misses      15178    15177       -1     
Flag Coverage Δ
unittests 47.81% <54.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenyukang chenyukang changed the title Add waiting_tlc_ack for HTLC operations Rewrite channel actor state tlc operations Nov 29, 2024
@chenyukang chenyukang force-pushed the yukang-fix-htls-ops branch 7 times, most recently from e0c3883 to 7f9ed4e Compare December 2, 2024 11:17
@chenyukang chenyukang marked this pull request as ready for review December 2, 2024 12:32
@chenyukang chenyukang force-pushed the yukang-fix-htls-ops branch 4 times, most recently from 1080207 to d171b9f Compare December 4, 2024 02:16
@chenyukang chenyukang marked this pull request as draft December 4, 2024 02:55
@chenyukang chenyukang marked this pull request as ready for review December 4, 2024 08:37
@chenyukang chenyukang force-pushed the yukang-fix-htls-ops branch 4 times, most recently from fde81fd to 658123a Compare December 5, 2024 03:48
@quake quake merged commit fb7466d into nervosnetwork:main Dec 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants