Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude live cells used by ongoing funding tx #521

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

doitian
Copy link
Member

@doitian doitian commented Feb 26, 2025

Based on #519

@doitian
Copy link
Member Author

doitian commented Feb 26, 2025

@chenyukang Once abandon_channel is added, it should send RemoveFundingTx to tell chain actor to release the live cells.

@doitian doitian force-pushed the feature/funding-tx-exclusion-map branch from bd41f62 to 6e5d564 Compare February 26, 2025 02:44

#[derive(Debug, Default, Clone)]
pub struct LiveCellsExclusionMap {
map: HashMap<packed::Byte32, LiveCellsExclusion>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this LiveCellsExclusionMap persisted in db?

@doitian doitian force-pushed the feature/funding-tx-exclusion-map branch 4 times, most recently from 5b6ed78 to 4415c1a Compare March 1, 2025 00:11
@doitian doitian force-pushed the feature/funding-tx-exclusion-map branch from 4415c1a to 6fa743c Compare March 1, 2025 00:16
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 44.23792% with 300 lines in your changes missing coverage. Please review.

Project coverage is 49.78%. Comparing base (7d928dc) to head (6fa743c).

Files with missing lines Patch % Lines
src/ckb/tx_tracing_actor.rs 0.00% 116 Missing ⚠️
src/ckb/actor.rs 6.34% 59 Missing ⚠️
src/ckb/funding/funding_tx.rs 0.00% 45 Missing ⚠️
src/fiber/channel.rs 26.82% 30 Missing ⚠️
src/fiber/in_flight_ckb_tx_actor.rs 87.78% 16 Missing ⚠️
src/ckb/jsonrpc_types_convert.rs 0.00% 15 Missing ⚠️
src/fiber/gossip.rs 71.42% 10 Missing ⚠️
src/fiber/network.rs 89.77% 9 Missing ⚠️

❌ Your patch status has failed because the patch coverage (44.23%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #521      +/-   ##
===========================================
- Coverage    49.92%   49.78%   -0.14%     
===========================================
  Files           49       52       +3     
  Lines        32455    32820     +365     
===========================================
+ Hits         16202    16339     +137     
- Misses       16253    16481     +228     
Flag Coverage Δ
unittests 49.78% <44.23%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants