-
Notifications
You must be signed in to change notification settings - Fork 375
Fix for issue 3442 #3445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix for issue 3442 #3445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good already. I have a few suggestions for further improvement. I also wonder if we should go "all in" in the CI and in our "everything" test also activate detailed and mpi-sync timer. That will slow the testsuite a little, but at least we test all. That would require adding something like "detailed_timers" and "mpi_sync_timer" to
- "openmp, mpi, python, gsl, ltdl, boost, hdf5, sionlib, libneurosim, optimize, warning, music" |
-Dwith-music=${{ contains(matrix.use, 'music') && '$HOME/.cache/music.install' || 'OFF' }} \ |
I downgraded severity to "high" because it is a bug that only occurs under specific circumstances. |
Co-authored-by: Hans Ekkehard Plesser <[email protected]>
This reverts commit dc664bb.
I agree, adding detailed timers and the mpi-sync-timer to the "full" CI testcase makes sense. It shouldn't slow it down too much, so we should be fine. |
@terhorstd Could you take a look at this one especially with a view to the changes in the build matrix? |
@terhorstd Ping! |
@terhorstd You only need to review the changes in |
This PR fixes issue #3442.