Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(microservices): let use unicode characters in TCP Microservice… #1795

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Conversation

ivibe
Copy link
Contributor

@ivibe ivibe commented Mar 20, 2019

… messages

add own json-socket implementation

#1734

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

Issue Number: #1734

What is the new behavior?

Unicode characters in TCP Microservice messages don't cause errors

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The core algorithm was borrowed from original json-socket package (https://github.com/sebastianseilund/node-json-socket). Basically all unnecessary code was removed, only the core functionality was kept.

@coveralls
Copy link

coveralls commented Mar 20, 2019

Pull Request Test Coverage Report for Build 2034

  • 84 of 92 (91.3%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 93.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/json-socket.ts 50 53 94.34%
packages/microservices/test/json-socket/helpers.ts 28 33 84.85%
Totals Coverage Status
Change from base Build 2033: -0.08%
Covered Lines: 3078
Relevant Lines: 3231

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2034

  • 84 of 92 (91.3%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 93.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/json-socket.ts 50 53 94.34%
packages/microservices/test/json-socket/helpers.ts 28 33 84.85%
Totals Coverage Status
Change from base Build 2033: -0.08%
Covered Lines: 3078
Relevant Lines: 3231

💛 - Coveralls

@BrunnerLivio

This comment has been minimized.

@kamilmysliwiec

This comment has been minimized.

@kamilmysliwiec
Copy link
Member

Thank you :) LGTM

@kamilmysliwiec kamilmysliwiec merged commit 9c3e15a into nestjs:master Mar 26, 2019
@ivibe
Copy link
Contributor Author

ivibe commented Mar 26, 2019

Glad to help!

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants